Interact with dao contract functions #104

0xExp-po · 2024-12-03T08:28:38Z

create a create proposal function

netlify · 2024-12-03T08:28:56Z

✅ Deploy Preview for tansu canceled.

Name	Link
🔨 Latest commit	`0588b41`
🔍 Latest deploy log	https://app.netlify.com/sites/tansu/deploys/675a2c342b2a8d000863c537

netlify · 2024-12-03T08:29:22Z

❌ Deploy Preview for testnet-tansu failed. Why did it fail? →

Name	Link
🔨 Latest commit
🔍 Latest deploy log	https://app.netlify.com/sites/testnet-tansu/deploys/675a3003eb0819b171c8d695

tupui · 2024-12-04T01:15:07Z

dapp/src/components/page/governance/ProposalForm.tsx

+        projectName,
+        proposalName,
+        directoryCid.toString(),
+        Date.now() + 86400000 * import.meta.env.PUBLIC_VOTING_PERIOD,


This needs to be configurable from the user side

tupui

Thanks, I left a few suggestions.

I will test it locally now and get back to you.

tupui · 2024-12-04T22:19:29Z

dapp/src/constants/demoProposalData.ts

We don't need any demo data no? I think you can create all the real proposals from the demo instead. I will try to make one with this branch locally.

tupui · 2024-12-04T22:21:06Z

dapp/src/constants/contractErrorMessages.ts

You should not redefine these, everything is defined in the contracts bindings already. The point of this error task was to do some automatic error handling of the contract and show the proper error if the contract fails instead of a number or no error message at all.

the contract error messages are for the alert to users what contract error occurs.
if we need some other automatic error handling not only error alert, I'll update the response data type which means the service functions only return errorCode, then in the component, according to the errorCode, I'll alert error message and do the other error handling actions.
how do you think about it?

I meant this, we already define the errors in the bindings here and don't need to duplicate things.

soroban-versioning/dapp/packages/soroban_versioning/dist/index.js

Lines 19 to 31 in 2fac6ae

export const Errors = {

0: { message: "UnexpectedError" },

1: { message: "InvalidKey" },

2: { message: "ProjectAlreadyExist" },

3: { message: "UnregisteredMaintainer" },

4: { message: "NoHashFound" },

5: { message: "InvalidDomainError" },

6: { message: "MaintainerNotDomainOwner" },

7: { message: "ProposalInputValidation" },

8: { message: "NoProposalorPageFound" },

9: { message: "AlreadyVoted" },

10: { message: "ProposalVotingTime" },

};

So, should I alert this messages to the users?

tupui · 2024-12-04T23:16:39Z

dapp/src/components/page/governance/ProposalForm.tsx

+    if (!isDescriptionValid(rejectDescription)) {
+      alert("Rejected description must contain at least 3 words.");
+      return;
+    }
+
+    if (!isDescriptionValid(cancelledDescription)) {
+      alert("Cancelled description must contain at least 3 words.");
+      return;
+    }


Actually it's more complicated. Only for approval it's a must to have a description. For reject and cancelled, description is only required if there is a XDR.

While we are here, if no XDR is provided or no description, then in the UI we don't need to show this specific outcome. I expect that a lot of proposals will just have an approve outcome and the rest will be empty. So we don't need to show empty outcomes.

tupui · 2024-12-04T23:18:25Z

dapp/src/components/page/governance/ProposalForm.tsx

+      return;
+    }
+
+    if (votingDays < 5 || votingDays > 30) {


Make it 1 for the min. 5 is a bit much.

tupui · 2024-12-04T23:34:22Z

dapp/src/components/page/governance/ProposalForm.tsx

      const directoryCid = await client.uploadDirectory(files);

-      setIsLoading(false);
-      alert(
-        `Proposal submitted successfully! CID: ${getIpfsBasicLink(directoryCid.toString())}`,
+      const { createProposal } = await import("@service/WriteContractService");
+
+      const res = await createProposal(


I feel that there should be some validation there to prevent calling the smart contract if IPFS upload failed.

Also, please see my suggestion in the IPFS issue to sign a challenge transaction and validate it backend side to get the IPFS token.

0xExp-po · 2024-12-06T01:39:02Z

I've update the Response data type.

export interface Response<T> {
  data: T | null;
  error: boolean;
  errorCode: number;
  errorMessage: string;
}

We can alert to users with errorMessage.
And according to the errorCode, we can add additional handling action.

…into Interact-DAO-contract

tupui

That's great, I will test locally the whole flow again and merge if that works

tupui · 2024-12-11T22:55:54Z

dapp/src/pages/api/w3up-delegation.js

@@ -47,11 +103,19 @@ async function backend(did) {
    "filecoin/offer",
    "upload/add",
  ];
-  const expiration = Math.floor(Date.now() / 1000) + 10;
+  const expiration = Math.floor(Date.now() / 1000) + 86400;


I understand that 10s might cause some issues, but 1 day is not reasonable either. What about 1 min?

tupui

Approving now as I tested locally and all works as expected. Great job 👏 Just waiting for you to address either here or in a follow up what we discussed.

tupui · 2024-12-11T23:58:39Z

dapp/src/constants/demoProposalData.ts

BTW, do we need this file at all now?

chore: separate connected key and kit service

dd2ed5b

0xExp-po added 3 commits December 3, 2024 23:35

chore: check empty descriptions before submit

9946702

chore: add proposal name input

92c3af1

chore: add create proposal function to new proposal page

9ba0fca

tupui reviewed Dec 4, 2024

View reviewed changes

0xExp-po added 13 commits December 4, 2024 12:04

fix: create proposal error

8b7474c

chore: add voting dates input

7886484

chore: update proposal data interface

740f421

feat: fetch proposals from contract

2356f07

feat: fetch proposal data from contract

677e55d

feat: implement vote function

c37fc13

chore: define the response type, create contract error messages

e1cf39c

chore: add error handler to voting function

c16daee

chore: change the response data type

da95617

chore: add error handler to submit proposal function

e80c248

chore: add error handler to commit hash function

820d203

chore: add error handler to register project function

bcac3df

feat: add error handler to read contract functions

ee71b0f

0xExp-po mentioned this pull request Dec 4, 2024

Error handling from contract in dApp #55

Open

tupui reviewed Dec 4, 2024

View reviewed changes

0xExp-po added 3 commits December 5, 2024 10:00

chore: remove demo proposal data

9713448

fix: update check condition for proposal submit

bd30995

chore: update contract response data type

773f2f5

0xExp-po added 4 commits December 6, 2024 11:01

chore: add process checker in submit proposal function

d8a4955

update stellar wallet kit version

8a385b9

chore: update submit proposal function

473de08

fix: linting error

3b66ef1

0xExp-po and others added 6 commits December 10, 2024 00:32

chore: add console log to check delegation

7258ee0

Fix signing and sending

0bd0e37

Merge branch 'main' of https://github.com/0xExp-po/soroban-versioning …

08dd2f4

…into Interact-DAO-contract

Merge branch 'main' of https://github.com/0xExp-po/soroban-versioning …

f13f3f3

…into Interact-DAO-contract

feat: create challenge to submit proposal

970016c

fix: regular expression for markdown image

3e8e2a6

tupui reviewed Dec 11, 2024

View reviewed changes

chore: set delegation expire time as 1 min

5e020db

tupui approved these changes Dec 11, 2024

View reviewed changes

tupui reviewed Dec 11, 2024

View reviewed changes

dapp/src/constants/demoProposalData.ts Outdated

Copy link

Owner

tupui Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we need this file at all now?

0xExp-po added 2 commits December 12, 2024 09:16

chore: divide proof env data into two parts

3c1b4ab

fix: linter error

0588b41

tupui approved these changes Dec 12, 2024

View reviewed changes

tupui merged commit fb668ef into tupui:main Dec 12, 2024
8 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interact with dao contract functions #104

Interact with dao contract functions #104

0xExp-po commented Dec 3, 2024

netlify bot commented Dec 3, 2024 •

edited

Loading

netlify bot commented Dec 3, 2024 •

edited

Loading

tupui Dec 4, 2024

0xExp-po Dec 4, 2024

tupui left a comment

tupui Dec 4, 2024

tupui Dec 4, 2024

0xExp-po Dec 5, 2024

tupui Dec 5, 2024

0xExp-po Dec 5, 2024

tupui Dec 4, 2024

tupui Dec 4, 2024

tupui Dec 4, 2024

0xExp-po commented Dec 6, 2024

tupui left a comment

tupui Dec 11, 2024

0xExp-po Dec 11, 2024

tupui left a comment

tupui Dec 11, 2024

	export const Errors = {
	0: { message: "UnexpectedError" },
	1: { message: "InvalidKey" },
	2: { message: "ProjectAlreadyExist" },
	3: { message: "UnregisteredMaintainer" },
	4: { message: "NoHashFound" },
	5: { message: "InvalidDomainError" },
	6: { message: "MaintainerNotDomainOwner" },
	7: { message: "ProposalInputValidation" },
	8: { message: "NoProposalorPageFound" },
	9: { message: "AlreadyVoted" },
	10: { message: "ProposalVotingTime" },
	};

Interact with dao contract functions #104

Interact with dao contract functions #104

Conversation

0xExp-po commented Dec 3, 2024

netlify bot commented Dec 3, 2024 • edited Loading

✅ Deploy Preview for tansu canceled.

netlify bot commented Dec 3, 2024 • edited Loading

❌ Deploy Preview for testnet-tansu failed. Why did it fail? →

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tupui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xExp-po commented Dec 6, 2024

tupui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tupui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Dec 3, 2024 •

edited

Loading

netlify bot commented Dec 3, 2024 •

edited

Loading