Merge pull request #138 from tumblr/daniel/new_strings

Add default values to Synthetic Strings
tumblr · Jun 28, 2022 · 34a8311 · 34a8311
2 parents 8b65319 + 0362ff0
commit 34a8311
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/Classes/Constants/KanvasStrings.swift b/Classes/Constants/KanvasStrings.swift
@@ -50,13 +50,11 @@ public struct KanvasStrings {
                                              cameraPermissionsDescriptionLabel: cameraPermissionDescriptionString)
 
     private static let cameraPermissionTitleString = {
-        NSLocalizedString("CameraAccessNoAccessTitle",
-                          comment: "Title text for scenerio when access to Photos has been disallowed")
+        NSLocalizedString("CameraAccessNoAccessTitle", value: "Please allow access to your camera and microphone", comment: "Title text for scenerio when access to Camera and microphone is required or has been disallowed")
     }()
 
     private static let cameraPermissionDescriptionString = {
-        NSLocalizedString("CameraAccessNoAccessDesc",
-                          comment: "Description text for scenerio when access to Photos has been disallowed")
+        NSLocalizedString("CameraAccessNoAccessDesc", value: "This functionality is required to post videos and photos", comment: "Description text for scenerio when access to Camera and microphone is required or has been disallowed")
     }()
 
     public init(cameraPermissionsTitleLabel: String,

diff --git a/Kanvas.podspec b/Kanvas.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |spec|
   spec.name         = "Kanvas"
-  spec.version      = "1.4.1"
+  spec.version      = "1.4.2"
   spec.summary      = "A custom camera built for iOS."
   spec.homepage     = "https://github.com/tumblr/kanvas-ios"
   spec.license      = "MPLv2"

diff --git a/KanvasExample/KanvasExample/en.lproj/Localizable.strings b/KanvasExample/KanvasExample/en.lproj/Localizable.strings
@@ -43,10 +43,10 @@
 /* Message for the post button in the editor screen */
 "Post" = "Post";
 
-/* Title text for scenerio when access to Photos has been disallowed */
-"CameraAccessNoAccessTitle" = "Please allow access to your camera and Microphone";
+/* Title text for scenerio when access to Camera and Mic is required or has been disallowed */
+"CameraAccessNoAccessTitle" = "Please allow access to your Camera and Microphone";
 
-/* Description text for scenerio when access to Photos has been disallowed */
+/* Description text for scenerio when access to Camera and Mic is required has been disallowed */
 "CameraAccessNoAccessDesc" = "You might want to save your post as a draft first so you don’t lose any unsaved progress.";
 
 /* Alert controller message */