only update attack/range actions

tullamods · Jan 25, 2020 · fa33dc6 · fa33dc6
1 parent fff6f71
commit fa33dc6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,9 @@
 # tullaRange release notes
 
+## 8.3.1
+
+* Increase performance a bit by only updating attack actions and actions with a range
+
 ## 8.3.0
 
 * Update for WoW 8.3.0

diff --git a/tullaRange/tullaRange.lua b/tullaRange/tullaRange.lua
@@ -13,7 +13,9 @@ local ATTACK_BUTTON_FLASH_TIME = _G.ATTACK_BUTTON_FLASH_TIME
 
 local IsActionInRange = _G.IsActionInRange
 local IsUsableAction = _G.IsUsableAction
-local HasAction = _G.HasAction
+local IsAttackAction = _G.IsAttackAction
+local ActionHasRange = _G.ActionHasRange
+-- local HasAction = _G.HasAction
 
 --[[
 	Helper Functions
@@ -227,7 +229,7 @@ end
 function Addon:UpdateButtonStatus(button)
 	local action = button.action
 
-	if action and button:IsVisible() and HasAction(action) then
+	if action and button:IsVisible() and (ActionHasRange(action) or IsAttackAction(action)) then
 		self.buttonsToUpdate[button] = true
 	else
 		self.buttonsToUpdate[button] = nil