feat : 그룹 캡슐 목록 조회 #476 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GaBaljaintheroom 이거 머지 순서 틀려서 다시 승인해주라 ㅜ 쏘리 |
…#479 # Conflicts: # backend/core/src/main/java/site/timecapsulearchive/core/domain/capsule/group_capsule/api/GroupCapsuleApi.java # backend/core/src/main/java/site/timecapsulearchive/core/domain/capsule/group_capsule/service/GroupCapsuleService.java # backend/core/src/test/java/site/timecapsulearchive/core/common/fixture/domain/CapsuleFixture.java # backend/core/src/test/java/site/timecapsulearchive/core/domain/capsule/group_capsule/repository/GroupCapsuleQueryRepositoryTest.java # backend/core/src/test/java/site/timecapsulearchive/core/domain/capsule/group_capsule/service/GroupCapsuleServiceTest.java
GaBaljaintheroom
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 (Content)
링크 (Links)
기타 사항 (Etc)
1은 한방 쿼리로 해결할 수 있긴하나 그룹원이 아닌데 그룹 정보를 조회하는 API에서 그룹원이 아닌데 조회가 된다는 것이 약간 논리적으로 이상하긴함
현재는 1번을 택해서 구현했음.
먼저 앞에 브랜치를 머지해버려서 다시올릴께;;
Merge 전 필요 작업 (Checklist before merge)
희망 리뷰 완료 일 (Expected due date)