Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 그룹 캡슐 개봉 로직 수정 #483 #486

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix : 그룹 캡슐 개봉 로직 수정 #483 #486

merged 3 commits into from
Jun 11, 2024

Conversation

seokho-1116
Copy link
Collaborator

작업 내용 (Content)

  • 그룹 캡슐 개봉 로직 수정(조건식을 ! + 긍정문을 부정문으로)
  • 개별 개봉 상태 추가

링크 (Links)

기타 사항 (Etc)

  • 개별 상태가 없어서 개별적으론 열어도 캡슐이 안열렸다고 내려가니 프론트에서 개별적으로 개봉된건지 캡슐이 개봉된건지 인지 불가능

Merge 전 필요 작업 (Checklist before merge)

희망 리뷰 완료 일 (Expected due date)

@seokho-1116
fix : 그룹 캡슐 개봉 로직 수정
c514fc4 
- allMatch의 단축 평가때문에 for loop으로 수정
@seokho-1116
test : 테스트 수정
82bf626
@seokho-1116 seokho-1116 added the api fix api 수정 요청 label Jun 9, 2024
@seokho-1116 seokho-1116 self-assigned this Jun 9, 2024
GaBaljaintheroom
GaBaljaintheroom approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@GaBaljaintheroom GaBaljaintheroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했엉~

@seokho-1116 seokho-1116 merged commit e5680e4 into develop_back_core Jun 11, 2024
2 checks passed
@seokho-1116 seokho-1116 deleted the fix/group_capsule_open-B-#483 branch June 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaBaljaintheroom GaBaljaintheroom GaBaljaintheroom approved these changes

Assignees

@seokho-1116 seokho-1116

Labels
api fix api 수정 요청
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seokho-1116 @GaBaljaintheroom