fix : 그룹 관련 요청 및 응답 필드 수정 #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-1116
reviewed
May 31, 2024
...c/main/java/site/timecapsulearchive/core/domain/group/data/response/GroupsSliceResponse.java
Show resolved
Hide resolved
| @@ -30,7 +31,7 @@ public class GroupQueryRepositoryImpl implements GroupQueryRepository { | |||
|
|
|||
| private final JPAQueryFactory jpaQueryFactory; | |||
|
|
|||
| public Slice<GroupSummaryDto> findGroupsSlice( | |||
| public Slice<FinalGroupSummaryDto> findGroupsSlice( | |||
There was a problem hiding this comment.
이 레포지토리의 로직이 너무 집중되어있는데 서비스에서 해야할 것을 여기서 다해버리는 느낌이는데? 그룹 목록을 위해 순차적으로 조회하고 조립해서 나가는건 서비스 로직 느낌이 드네
| @@ -17,7 +18,6 @@ public class MemberGroupQueryRepositoryImpl implements MemberGroupQueryRepositor | |||
|
|
|||
| private final JPAQueryFactory jpaQueryFactory; | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
걍 없애도 되니깐 제외한건데, 명시적으로 @OverRide하는게 좋을까?
There was a problem hiding this comment.
난 명확해서 더 보기 편하다고 생각헀는데 어떻게 생각해?
There was a problem hiding this comment.
오케오케 좋은것같아
| import java.util.function.Function; | ||
| import site.timecapsulearchive.core.domain.group.data.response.GroupSummaryResponse; | ||
|
|
||
| public record FinalGroupSummaryDto( |
There was a problem hiding this comment.
Final이 뭐가 final인지 모르겠는디 좀 더 명확한게 좋을듯? 한국어로 말해보면 완벽히 조립된 그룹 정보 이런거라던지
|
테스트 깨졌는데? 확인 필요할듯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 (Content)
링크 (Links)
기타 사항 (Etc)
Merge 전 필요 작업 (Checklist before merge)
희망 리뷰 완료 일 (Expected due date)
202X. X. X. Wed