-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #456 from tukcomCD2024/performance/group_detail-B-…
…#455 performance : 그룹 상세조회 쿼리 개선
- Loading branch information
Showing
7 changed files
with
207 additions
and
87 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
175 changes: 175 additions & 0 deletions
175
...va/site/timecapsulearchive/core/domain/group/repository/GroupQueryRepositoryImplTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| package site.timecapsulearchive.core.domain.group.repository; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import com.querydsl.jpa.impl.JPAQueryFactory; | ||
| import jakarta.persistence.EntityManager; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import org.assertj.core.api.SoftAssertions; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.test.context.TestConstructor; | ||
| import org.springframework.test.context.TestConstructor.AutowireMode; | ||
| import org.springframework.transaction.annotation.Transactional; | ||
| import site.timecapsulearchive.core.common.RepositoryTest; | ||
| import site.timecapsulearchive.core.common.fixture.domain.GroupFixture; | ||
| import site.timecapsulearchive.core.common.fixture.domain.MemberFixture; | ||
| import site.timecapsulearchive.core.common.fixture.domain.MemberGroupFixture; | ||
| import site.timecapsulearchive.core.domain.group.data.dto.GroupDetailDto; | ||
| import site.timecapsulearchive.core.domain.group.data.dto.GroupMemberDto; | ||
| import site.timecapsulearchive.core.domain.group.entity.Group; | ||
| import site.timecapsulearchive.core.domain.member.entity.Member; | ||
| import site.timecapsulearchive.core.domain.member_group.entity.MemberGroup; | ||
|
|
||
| @TestConstructor(autowireMode = AutowireMode.ALL) | ||
| class GroupQueryRepositoryImplTest extends RepositoryTest { | ||
|
|
||
| private final GroupQueryRepository groupQueryRepository; | ||
|
|
||
| private Long groupId; | ||
| private Long ownerId; | ||
| private Long groupMemberId; | ||
|
|
||
| GroupQueryRepositoryImplTest(JPAQueryFactory jpaQueryFactory) { | ||
| this.groupQueryRepository = new GroupQueryRepositoryImpl(jpaQueryFactory); | ||
| } | ||
|
|
||
| @Transactional | ||
| @BeforeEach | ||
| void setup(@Autowired EntityManager entityManager) { | ||
| Group group = GroupFixture.group(); | ||
| entityManager.persist(group); | ||
| groupId = group.getId(); | ||
|
|
||
| Member member = MemberFixture.member(1); | ||
| entityManager.persist(member); | ||
| ownerId = member.getId(); | ||
|
|
||
| MemberGroup memberGroup = MemberGroupFixture.groupOwner(member, group); | ||
| entityManager.persist(memberGroup); | ||
|
|
||
| List<Member> members = MemberFixture.members(2, 10); | ||
| for (Member m : members) { | ||
| entityManager.persist(m); | ||
|
|
||
| MemberGroup mg = MemberGroupFixture.memberGroup(m, group, Boolean.FALSE); | ||
| entityManager.persist(mg); | ||
| } | ||
| groupMemberId = members.get(0).getId(); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹_아이디와_멤버_아이디로_그룹을_조회하면_그룹_상세가_반환된다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetail = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, ownerId).orElseThrow(); | ||
|
|
||
| //then | ||
| assertThat(groupDetail).isNotNull(); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹_아이디와_멤버_아이디로_그룹을_조회하면_그룹_정보를_볼_수_있다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetail = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, ownerId).orElseThrow(); | ||
|
|
||
| //then | ||
| SoftAssertions.assertSoftly(softly -> { | ||
| assertThat(groupDetail.groupName()).isNotBlank(); | ||
| assertThat(groupDetail.groupDescription()).isNotBlank(); | ||
| assertThat(groupDetail.groupProfileUrl()).isNotBlank(); | ||
| assertThat(groupDetail.createdAt()).isNotNull(); | ||
| assertThat(groupDetail.members()).isNotEmpty(); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹_아이디와_멤버_아이디_그룹을_조회하면_그룹원들의_정보를_볼_수_있다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetail = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, groupMemberId).orElseThrow(); | ||
|
|
||
| //then | ||
| SoftAssertions.assertSoftly(softly -> { | ||
| assertThat(groupDetail.members()).isNotEmpty(); | ||
| assertThat(groupDetail.members()).allSatisfy(m -> assertThat(m.memberId()).isNotNull()); | ||
| assertThat(groupDetail.members()).allSatisfy(m -> assertThat(m.tag()).isNotBlank()); | ||
| assertThat(groupDetail.members()).allSatisfy( | ||
| m -> assertThat(m.nickname()).isNotBlank()); | ||
| assertThat(groupDetail.members()).allSatisfy( | ||
| m -> assertThat(m.profileUrl()).isNotBlank()); | ||
| assertThat(groupDetail.members()).allSatisfy(m -> assertThat(m.isOwner()).isNotNull()); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹_아이디와_멤버_아이디로_그룹을_조회하면_본인은_포함되어_조회되지_않는다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetail = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, groupMemberId).orElseThrow(); | ||
|
|
||
| List<GroupMemberDto> groupMemberDtos = groupDetail.members(); | ||
|
|
||
| //then | ||
| SoftAssertions.assertSoftly(softly -> { | ||
| softly.assertThat(groupMemberDtos) | ||
| .noneMatch(member -> member.memberId().equals(groupMemberId)); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹_아이디로_그룹을_상세정보를_조회하면_사용자를_제외한_그룹원의_정보를_볼_수_있다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetailDto = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, ownerId) | ||
| .orElseThrow(); | ||
|
|
||
| //then | ||
| assertThat(groupDetailDto.members()).noneMatch(m -> m.memberId().equals(ownerId)); | ||
| } | ||
|
|
||
| @Test | ||
| void 존재하지_않는_그룹_아이디로_그룹을_상세정보를_조회하면_예외가_발생한다() { | ||
| //given | ||
| Long notExistGroupId = 999L; | ||
|
|
||
| //when | ||
| Optional<GroupDetailDto> groupDetailDto = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| notExistGroupId, ownerId); | ||
|
|
||
| //then | ||
| assertThat(groupDetailDto).isEmpty(); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹장이_그룹을_상세정보를_조회하면_그룹의_수정권한을_가진다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetailDto = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, ownerId) | ||
| .orElseThrow(); | ||
|
|
||
| //then | ||
| assertThat(groupDetailDto.isOwner()).isTrue(); | ||
| } | ||
|
|
||
| @Test | ||
| void 그룹원이_그룹을_상세정보를_조회하면_그룹의_수정권한이_없다() { | ||
| //given | ||
| //when | ||
| GroupDetailDto groupDetailDto = groupQueryRepository.findGroupDetailByGroupIdAndMemberId( | ||
| groupId, groupMemberId) | ||
| .orElseThrow(); | ||
|
|
||
| //then | ||
| assertThat(groupDetailDto.isOwner()).isFalse(); | ||
| } | ||
| } |
Oops, something went wrong.