Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Add support for PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet #874

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olokobayusuf
Copy link

@olokobayusuf olokobayusuf commented Oct 29, 2024

Resolves #838

Short description 📝

This PR adds support for PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet in Xcode 16.

Solution 📦

It builds upon #827 .

Implementation 👩‍💻👨‍💻

  • Add PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet type and support for deserializing from a .pbxproj file.
  • Update PBXFileSystemSynchronizedRootGroup.exceptions field type to abstract base PBXFileSystemSynchronizedExceptionSet type to cover PBXFileSystemSynchronizedBuildFileExceptionSet.
  • Add support for setting and serializing PBXFileSystemSynchronizedRootGroup.exception.
  • Add tests.

@pepicrft
Copy link
Contributor

Is this ready for review?

@olokobayusuf
Copy link
Author

@pepicrft not yet, I gotta add tests. Will try to get this finalized this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Xcode 16's PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet
2 participants