Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #141

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Maintenance #141

merged 5 commits into from
Dec 23, 2023

Conversation

ahueck
Copy link
Contributor

@ahueck ahueck commented Dec 23, 2023

System: Source location

  • Improve source location detection via built_in_return_addr by correctly calculating the ptr offset
  • Avoid lib preload-induced endless recusions when querying the source loc

Tests

  • Detect and use the correct Python3 interpreter

@ahueck
Use found python interp for tests
283adb4
@ahueck
Remove failing file check
1c01293
@ahueck
Revert CMake formatting
a984807
@ahueck
Improve source loc handling
7ed33da 
* Correct offset calculation with VMA addr translation
* Remove preloads to mitigate endless recursion when preloading
@ahueck
Pass hex value to addr2line
7b18b61
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7308513260

  • 23 of 28 (82.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.857%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/support/System.cpp 23 28 82.14%
Totals Coverage Status
Change from base Build 3933287174: 0.1%
Covered Lines: 3617
Relevant Lines: 3981
💛 - Coveralls

@ahueck ahueck merged commit 223224d into devel Dec 23, 2023
39 checks passed
@ahueck ahueck deleted the feat/maintenance branch December 23, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahueck @coveralls