feedback formatting, test, avoid inline if (bunq#93)

at the cost of risk for index-out-of-bounds (prior code)
tubbynl · Jun 19, 2018 · 0bc1987 · 0bc1987
1 parent d77e23d
commit 0bc1987
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/com/bunq/sdk/model/core/UserContextHelper.java b/src/main/java/com/bunq/sdk/model/core/UserContextHelper.java
@@ -31,7 +31,7 @@ public User getFirstUser() {
     BunqResponseRaw responseRaw = getRawResponse(USER_URL);
     BunqResponse<List<User>> response = fromJsonList(User.class, responseRaw);
 
-    return !response.getValue().isEmpty()?response.getValue().get(FIRST):null;
+    return response.getValue().get(FIRST);
   }
 
   public MonetaryAccountBank getFirstActiveMonetaryAccountBankByUserId(Integer userId) {

diff --git a/src/test/java/com/bunq/sdk/context/UserContextTest.java b/src/test/java/com/bunq/sdk/context/UserContextTest.java
@@ -8,12 +8,13 @@
 public class UserContextTest extends BunqSdkTestBase {
 
     @Test
-    public void testConstruct() {
+    public void buildUserContext() {
         ApiContext context = getApiContext();
 
-        UserContext sut = new UserContext(context);
+        UserContext userContext = new UserContext(context);
 
-        assertNotNull(sut.getUserId());
-        assertNotNull(sut.getMainMonetaryAccountId());
+        assertNotNull(userContext.getUserId());
+        assertNotNull(userContext.getMainMonetaryAccountId());
     }
 }
+