Enable Resource Type facet in search #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippgualdi
force-pushed
the
feature-search-resource-type-facet
branch
from
b9dd9a1
to
d643727
Compare
philippgualdi
force-pushed
the
feature-search-resource-type-facet
branch
from
d643727
to
80ca73a
Compare
philippgualdi
changed the title
| @@ -90,9 +92,6 @@ class Marc21RecordServiceConfig(RecordServiceConfig, ConfiguratorMixin): | |||
| schema_secret_link = None | |||
| review = None | |||
|
|
|||
| # Permission policy | |||
There was a problem hiding this comment.
does this change belongs to the resource_type addition?
There was a problem hiding this comment.
does this change belongs to the resource_type addition?
No this line is a duplet and gets overwritten later in the config.
utnapischtim
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces functionality to allow users to filter records by resource type. This enhancement aims to improve the usability and efficiency of our search capabilities, enabling users to filter records more precisely based on the type of resource they are interested in.
Background
The ability to filter by resource type has been a frequently requested feature from our user community. Previously, users could only filter records based on access type. This limitation made it challenging for users to narrow down search results to specific types of resources.
Changes
Benefits
Enhanced Data Organization: By categorizing records by resource type, we can offer more structured and organized search results.
Demo