This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
WIP: Add support to haproxy's proxy-protocol #34
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
The PR adds support to HAProxy to reverse proxy engines. Only proxy-protocol v2 will be supported as it's both easier and faster to parse.
Done:
Missing:
Caveats:
There are some major possible performance implications in the native reverseproxy implementation. Reading the proxy protocol's header happens when we receive a
StateNew
ConnState() call and it blocks until we've finished reading the header, as we must preventhttp.Server
from reading from this connection until we're done. The problem is thathttp.Server
calls thesetState
before a new goroutine is spawned for the new connection, this means we're blocking theAccept
loop thus delaying accepting new connections. I don't see a better way for now besides checking with the Go team for the possibility of including a new connection state triggered from inside the new goroutine.Fixes #33