Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes 2 changes:
cimport numpy as cnp
instead ofnp
to differentiateimport
fromcimport
as suggested in https://cython.readthedocs.io/en/latest/src/tutorial/numpy.html#adding-typesnp.int_t
type bylong
to restore the typed defined in numpy v1: see https://github.com/numpy/numpy/blob/v1.26.5/numpy/__init__.pxd#L258 and https://github.com/numpy/numpy/blob/v1.26.5/numpy/__init__.pxd#L712).closes #239