Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING bot PR254 with EESSI/SWL PR467 (Run test suite based on pr366) #69

Open
wants to merge 166 commits into
base: 2023.06-software.eessi.io
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
166 commits
Select commit Hold shift + click to select a range
6cc2e3e
first version of bot/test.sh script
truib Oct 14, 2023
9a32dc6
scripts to run tests after a build job has finished
truib Oct 15, 2023
17cfd02
small adjustments to test script
truib Oct 15, 2023
0f3646e
Second attempt at having the bot run the test suite, now based on Tho…
Feb 5, 2024
e8c91eb
Merge upstream into old feature branch based on pr366
Feb 5, 2024
34fca15
Make a very simple change to an easystack file so we are able to trig…
Feb 5, 2024
3faae9d
Make scripts executable
Feb 6, 2024
081e2b1
Check for existence of SLURM output first
Feb 6, 2024
9b6fa73
Clarify return messages from the bot
Feb 6, 2024
cb48b36
Use EESSI_SOFTWARE_PATH instead of EASYBUILD_INSTALLPATH to set the m…
Feb 6, 2024
d1a0219
Do git clone in a seperate script, so that that can be run in the pre…
Feb 6, 2024
86d5d3d
Should use the one from current dir
Feb 6, 2024
7861aec
Remove quotes, see if that helps
Feb 6, 2024
a7b5ee1
Apparently, we need to remove curly braces too
Feb 6, 2024
f50e463
Make sure this actually gets reported as failure, as the ReFrame runt…
Feb 6, 2024
f67df9b
Fix the actual issue: make sure that two arguments are interpreted se…
Feb 6, 2024
3394851
See if we can make check-test formatting more fancy
Feb 6, 2024
8e5682a
Replace the env var for the result file
Feb 6, 2024
6cf0cf9
Add missing functions
Feb 6, 2024
7fe24e1
Remove artefacts from reporting
Feb 6, 2024
afc309a
Add a reason for the failure
Feb 6, 2024
b84e487
Fixed missing bracket
Feb 6, 2024
ef7bc01
Add reporting of the ReFrame result
Feb 6, 2024
867681a
Add missing bracket. Again
Feb 6, 2024
47e30ca
Add some echo for debugging
Feb 6, 2024
1bdadf8
more debugging output
Feb 6, 2024
5152f5e
Lets try some nicer formatting with headers etc. See if this actually…
Feb 6, 2024
ea38c66
Inverse check, it was incorrect
Feb 6, 2024
8edb6ff
Remove debugging output
Feb 6, 2024
26bd2cb
Correct the regex pattern to account for the fact that the slurm outp…
Feb 6, 2024
416b72d
Corrected typo
Feb 6, 2024
1990093
Trigger failure in the workflow on purpose, to show what that looks like
Feb 6, 2024
4b98856
Change order of checking error codes. If the ReFrame tests ran and we…
Feb 6, 2024
0f26142
Make sure we don't overwrite the grepped result from failures
Feb 7, 2024
94e0bb5
Fix plural/singular typo
Feb 7, 2024
9e7ac1c
Be a bit more expressive about what we are doing
Feb 7, 2024
3a52bde
Change to dedicated config file for testing by the bot in the build job
Feb 7, 2024
159e384
Make it verbose, see if we can see why autodetect fails
Feb 7, 2024
b92044e
Add ReFrame config template. Not that four template variables need to…
Feb 7, 2024
02b0e31
Use template config file and make replacements based on lscpu
Feb 7, 2024
58c4cfa
Fix incorrect variable name
Feb 7, 2024
2fc121e
Missing comma
Feb 7, 2024
db08f4f
Corrected typo
Feb 7, 2024
6b3a6cc
Remove verbose flags
Feb 7, 2024
a70b4f1
Pick name without spaces, to avoid issues with directories
Feb 7, 2024
ce24e6d
Pick more meaningful name for SLURM variable, namely SLURM_OUTPUT_FOUND
Feb 8, 2024
9881c2a
Correct erroneous status
Feb 8, 2024
1446055
Rename CoDeList variable to comment_details_list
Feb 8, 2024
f80c0eb
Remove commented section, it is not relevant
Feb 8, 2024
ff5baac
Update run_tests.sh
casparvl Feb 8, 2024
4adae18
Fix mistake in replacing SLURM with SLURM_OUTPUT_FOUND
Feb 8, 2024
848e387
Merge branch 'run_test_suite_based_on_pr366' of github.com:casparvl/s…
Feb 8, 2024
9e6955f
Change name of the template for the ReFrame config file to make clear…
Feb 8, 2024
08a7fd8
Fix typo in variable
Feb 8, 2024
8b5bde5
No longer needed
Feb 8, 2024
5d383eb
Added header, rephrased some comments
Feb 8, 2024
cdf7971
Fix headers
Feb 8, 2024
79a9ad3
Load default ReFrame version
Feb 8, 2024
2f280e4
Point to docs for ReFrame config
Feb 8, 2024
e5d60b9
Fix silly mistake: I was overwriting the ReFrame config file with eve…
Feb 8, 2024
b5c60cc
See if @boegel is correct and if we don't actually need ANY software …
Feb 8, 2024
7fc04d8
{2023.06}[foss/2022b] ImageMagick v7.1.0-53
truib Feb 11, 2024
69d6d2e
Add escape character to star, so that the regex pattern prints correc…
Feb 14, 2024
8491f9f
Always use LMOD_RC file, and make sure loading CUDA apps always works…
ocaisa Feb 15, 2024
2dd048e
Add the list(SCALES.keys()) feature (though technically we could limi…
Feb 15, 2024
0492b9e
Try the original regex patterns, capturing spaces more specifically, …
Feb 15, 2024
0f6dc76
Update eessi-2023.06-eb-4.9.0-2022b.yml
Neves-P Feb 16, 2024
3bac711
Add waLBerla v6.1 foss2022b
Neves-P Feb 16, 2024
d6e4cec
add missing ':' for waLBerla entry
boegel Feb 17, 2024
b860c5b
Merge pull request #478 from Neves-P/2023.06-software.eessi.io-waLBer…
bedroge Feb 19, 2024
ec61759
Remove manual setup of MODULEPATH etc, and source the regular EESSI i…
Feb 19, 2024
f3f9721
{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0
Feb 20, 2024
f8cd2aa
Remove AOFlagger (Lua is no longer part of filter-deps)
Feb 20, 2024
eafbb6b
Include easyblocks from pr 3088 to fix Python path
Feb 20, 2024
df089de
Fix typo
Feb 20, 2024
2ec41e1
List dependencies first
Feb 21, 2024
d0ba0b7
fix typo in IDG version
bedroge Feb 21, 2024
5d797a9
Include Armadillo-12.8.0-foss-2023b.eb
Feb 21, 2024
a55826d
Revert "Include Armadillo-12.8.0-foss-2023b.eb"
Feb 21, 2024
f63a4d8
Include Armadillo-12.8.0-foss-2023b.eb
Feb 21, 2024
7a0aceb
Include arpack-ng-3.9.0-foss-2023b.eb
Feb 21, 2024
5c546ea
Disable 'vectorize' toolchain option for casacore 3.5.0 on aarch64/ne…
Feb 22, 2024
5b822a3
Remove empty line
Feb 22, 2024
8892437
Cleanup code
Feb 22, 2024
3dcf5fa
add WRF-4.4.1-foss-2022b-dmpar.eb
bedroge Feb 22, 2024
129d66b
Merge pull request #480 from bedroge/wrf_4.4.1_2022b
boegel Feb 23, 2024
4e5f2db
Retrieve cpu_target from EESSI env vars
t1mk1k Feb 23, 2024
3544073
Specify print message for skipping non-neoverse_v1
Feb 23, 2024
0aea4b4
Create toolchainopts dict if it does not exist
Feb 26, 2024
07296d3
Enable lax vector conversion for DP3
Feb 27, 2024
793e9f8
{2023.06}[foss/2023a] dask v2023.9.2
Feb 28, 2024
68a766f
fixed info
Feb 28, 2024
3cdf803
removed the hook and added --from-pr
Feb 28, 2024
1170818
Temporary fix for CI by pinning archspec version
ocaisa Feb 29, 2024
eb5d57e
Merge pull request #482 from ocaisa/fix_ci
boegel Feb 29, 2024
d7ae0de
Merge branch '2023.06-software.eessi.io' of gh-nessi:EESSI/software-l…
Feb 29, 2024
cf77056
remove-blanks
TopRichard Feb 29, 2024
887e102
Update easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-20…
ocaisa Feb 29, 2024
938e52e
Update easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-20…
ocaisa Feb 29, 2024
301ab59
Make check_missing_installations.sh check against develop branch of E…
ocaisa Feb 29, 2024
93d1d7d
Use filename rather than full path
ocaisa Feb 29, 2024
f6259dc
export envvar
ocaisa Feb 29, 2024
34f3be0
Merge pull request #481 from TopRichard/eessi-2023.06-dask/9.2-foss/2…
ocaisa Mar 1, 2024
5e7c6bb
Merge pull request #486 from ocaisa/tweak_check_missing
boegel Mar 1, 2024
78ba8d8
Adding OSU microbenchmarks with GPU support for 2023a, and one withou…
Mar 1, 2024
1fd1609
'which' is not working in the container, command -v is
Mar 1, 2024
3141789
Workaround for 'PSM3 can't open nic unit' error
Mar 1, 2024
a28e5ee
Merge pull request #487 from casparvl/osu_gpu
ocaisa Mar 1, 2024
efbeb56
Use LMOD_CONFIG_DIR instead of LMOD_RC to allow user overrides of wha…
Mar 4, 2024
590cabd
Combine functions into a single function, before registering this as …
Mar 5, 2024
0de249e
Look for site-specific lmodrc file in host_injections. If present, se…
Mar 5, 2024
c1840dd
Next the local lmodrc within the versioned directory, e.g. /cvmfs/sof…
Mar 6, 2024
df4140a
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
78e582b
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
77c9723
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
276a64c
{2023.06}[gompi/2023b] CDO v2.2.2
Mar 7, 2024
4c22e55
Merge pull request #492 from TopRichard/eessi-2023.06-CDO/2.2.2-gompi…
ocaisa Mar 7, 2024
e33938f
Revert changes in eessi_environment_variables. Limit this PR to the b…
Mar 7, 2024
8dc4d2a
Merge pull request #490 from casparvl/change_lmodrc_setup
ocaisa Mar 7, 2024
45022b6
Allow for open PRs when checking missing installations in build script
ocaisa Mar 8, 2024
723fce8
Check for unmerged EasyConfig output pattern
Mar 9, 2024
5cd559e
Merge branch 'tweak_missing_installs' into improve_error_on_unmerged_pr
Mar 9, 2024
f4f2776
First, try without --from-pr. If that fails, try with --from-pr, but …
Mar 9, 2024
b789108
Add CFITSIO as a test example, see if we can get a clear error messag…
Mar 9, 2024
d178a8f
Added clarifying comment
Mar 9, 2024
9123c9c
Correct mistake: I meant to _move_ the awk part, not duplicate it
Mar 9, 2024
7e44223
Now actually check against the exit code of the pipe...
Mar 9, 2024
da749a1
Make seperate exit code for the run that allows --from-pr
Mar 9, 2024
86d8a36
Remove ineffective DP3 hook
Mar 11, 2024
790756b
Merge upstream changes into branch
Mar 11, 2024
f8816ac
{2023.06}[2023a] JupyterNotebook v7.0.2
boegel Mar 11, 2024
a8c2883
Correct typo
casparvl Mar 11, 2024
6553e29
Skip the if-condition also if pr_exceptions is empty. There is no poi…
Mar 11, 2024
8990e37
Merge branch 'improve_error_on_unmerged_pr' of github.com:casparvl/so…
Mar 11, 2024
8fc3fc4
Merge pull request #495 from boegel/2023.06-software.eessi.io_Jupyter…
bedroge Mar 12, 2024
6fee4c9
Merge pull request #479 from t1mk1k/new_pr_wsclean_dp3_2023b
ocaisa Mar 12, 2024
0343684
{2023.06}[foss/2023b] python-casacore 3.5.2 + libspatialindex 1.9.3
Mar 12, 2024
af55c71
Merge branch '2023.06-software.eessi.io' into 2023.06-software-imagem…
bedroge Mar 12, 2024
3e43b06
add ImageMagick-7.1.1-15-GCCcore-12.3.0.eb
bedroge Mar 12, 2024
75735ac
Merge pull request #470 from trz42/2023.06-software-imagemagick-foss-…
boegel Mar 12, 2024
25917ba
Merge pull request #498 from bedroge/imagemagick_2023a
boegel Mar 12, 2024
0295571
Use PR that sets LD_LIBRARY_PATH for python-casacore
Mar 12, 2024
222d929
Merge pull request #497 from t1mk1k/new_pr_python_casacore_libspatial…
bedroge Mar 12, 2024
bc84aec
Merge pull request #475 from ocaisa/always_lmod_rc
boegel Mar 13, 2024
b52db4b
Merge branch '2023.06-software.eessi.io' into improve_error_on_unmerg…
boegel Mar 13, 2024
c08831e
Update bot/check-build.sh
ocaisa Mar 13, 2024
992b11d
Remove PR to trigger comment
ocaisa Mar 13, 2024
8d6493e
Trigger on any non-zero exit code
ocaisa Mar 13, 2024
1dee560
Merge pull request #494 from casparvl/improve_error_on_unmerged_pr
boegel Mar 13, 2024
0fdbd3a
Add Z3 with new module name
ocaisa Mar 14, 2024
dd75723
Merge pull request #502 from EESSI/ocaisa-patch-6
bedroge Mar 14, 2024
d097189
{2023.06}[2023a] PyOpenGL 3.1.7
boegel Mar 14, 2024
8245aff
add from-pr=20007
bedroge Mar 14, 2024
06a0413
Merge pull request #503 from boegel/2023.06-software.eessi.io_2023a_P…
bedroge Mar 15, 2024
af58e1a
{2023.06}[2023a] ipympl 0.9.3
boegel Mar 15, 2024
a12b9a3
fix check_missing_installations.sh when unmerged PR is used
boegel Mar 15, 2024
20c5c98
Merge pull request #506 from boegel/2023.06-software.eessi.io_fix-che…
ocaisa Mar 15, 2024
f4e1656
Merge branch '2023.06-software.eessi.io' into 2023.06-software.eessi.…
boegel Mar 15, 2024
974181d
Merge pull request #505 from boegel/2023.06-software.eessi.io_ipympl
bedroge Mar 16, 2024
536d323
Merge branch '2023.06-software.eessi.io' into run_test_suite_based_on…
casparvl Mar 22, 2024
330db7a
also dump status to test result file
boegel Mar 26, 2024
f3c6207
add Caspar as author in `bot/test.sh` script
boegel Mar 26, 2024
13072df
use read-only mode to access software installations via container
boegel Mar 26, 2024
1fa323a
fix typo: build -> test
boegel Mar 26, 2024
8d05473
disable CPU auto-detection in template ReFrame configuration script u…
boegel Mar 26, 2024
c53f578
pass down --generic to script used for running test suite, so tests a…
boegel Mar 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,38 @@ easyconfigs:
- matplotlib-3.8.2-gfbf-2023b.eb:
options:
from-pr: 19552
- AOFlagger-3.4.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- arpack-ng-3.9.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- Armadillo-12.8.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- casacore-3.5.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- IDG-1.2.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- EveryBeam-0.5.2-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- DP3-6.0-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- WSClean-3.4-foss-2023b.eb:
options:
from-pr: 19840
include-easyblocks-from-pr: 3088
- CDO-2.2.2-gompi-2023b.eb:
options:
from-pr: 19792
from-pr: 19792
33 changes: 30 additions & 3 deletions eb_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@


CPU_TARGET_NEOVERSE_V1 = 'aarch64/neoverse_v1'
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'

EESSI_RPATH_OVERRIDE_ATTR = 'orig_rpath_override_dirs'

Expand Down Expand Up @@ -160,6 +160,32 @@ def post_prepare_hook(self, *args, **kwargs):
POST_PREPARE_HOOKS[self.name](self, *args, **kwargs)


def parse_hook_casacore_disable_vectorize(ec, eprefix):
"""
Disable 'vectorize' toolchain option for casacore 3.5.0 on aarch64/neoverse_v1
Compiling casacore 3.5.0 with GCC 13.2.0 (foss-2023b) gives an error when building for aarch64/neoverse_v1.
See also, https://github.com/EESSI/software-layer/pull/479
"""
if ec.name == 'casacore':
tcname, tcversion = ec['toolchain']['name'], ec['toolchain']['version']
if (
LooseVersion(ec.version) == LooseVersion('3.5.0') and
tcname == 'foss' and tcversion == '2023b'
):
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if cpu_target == CPU_TARGET_NEOVERSE_V1:
if not hasattr(ec, 'toolchainopts'):
ec['toolchainopts'] = {}
ec['toolchainopts']['vectorize'] = False
print_msg("Changed toochainopts for %s: %s", ec.name, ec['toolchainopts'])
else:
print_msg("Not changing option vectorize for %s on non-neoverse_v1", ec.name)
else:
print_msg("Not changing option vectorize for %s %s %s", ec.name, ec.version, ec.toolchain)
else:
raise EasyBuildError("casacore-specific hook triggered for non-casacore easyconfig?!")


def parse_hook_cgal_toolchainopts_precise(ec, eprefix):
"""Enable 'precise' rather than 'strict' toolchain option for CGAL on POWER."""
if ec.name == 'CGAL':
Expand Down Expand Up @@ -327,7 +353,7 @@ def pre_configure_hook_wrf_aarch64(self, *args, **kwargs):
if LooseVersion(self.version) <= LooseVersion('3.9.0'):
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure_new.defaults && " % (pattern, repl))
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])

if LooseVersion('4.0.0') <= LooseVersion(self.version) <= LooseVersion('4.2.1'):
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure.defaults && " % (pattern, repl))
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])
Expand Down Expand Up @@ -414,7 +440,7 @@ def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs):
"""
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if self.name == 'netCDF' and self.version == '4.9.2' and cpu_target == CPU_TARGET_NEOVERSE_V1:
self.cfg['testopts'] = "|| echo ignoring failing tests"
self.cfg['testopts'] = "|| echo ignoring failing tests"

def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
"""
Expand Down Expand Up @@ -579,6 +605,7 @@ def inject_gpu_property(ec):


PARSE_HOOKS = {
'casacore': parse_hook_casacore_disable_vectorize,
'CGAL': parse_hook_cgal_toolchainopts_precise,
'fontconfig': parse_hook_fontconfig_add_fonts,
'OpenBLAS': parse_hook_openblas_relax_lapack_tests_num_errors,
Expand Down