Add initial test cases #38
Merged
+205
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-date
reviewed
Mar 16, 2024
|
I have fixed the pointed out issues. One point of concern is that I named it 'mock' based on the sample code from TCA, but thinking about it, 'dummy' might be a better choice. What do you think? |
d-date
reviewed
Mar 17, 2024
Comment on lines
45
to
46
| static public let testValue = Self() | ||
|
|
d-date
reviewed
Mar 17, 2024
| @@ -38,6 +38,7 @@ public struct Schedule { | |||
| case path(StackAction<Path.State, Path.Action>) | |||
| case destination(PresentationAction<Destination.Action>) | |||
| case view(View) | |||
| case fetchResponse(Result<(Conference, Conference, Conference), Error>) | |||
There was a problem hiding this comment.
Might be better with creating struct.
Suggested change
| case fetchResponse(Result<(Conference, Conference, Conference), Error>) | |
| case fetchResponse(Result<SchedulesResponse, Error>) |
The struct may be like below:
public struct SchedulesResponse: Equatable {
var day1: Conference
var day2: Conference
var workshop: Conference
}
Either is OK in this test. |
Co-authored-by: Daiki Matsudate <[email protected]>
d-date
approved these changes
Mar 18, 2024
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added first tests using TestStore.
Ref: #28