Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable-fast-updates #127

Merged
merged 1 commit into from
Nov 24, 2024
Merged

disable-fast-updates #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion product.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2382,5 +2382,6 @@
"vs/code/electron-sandbox/workbench/workbench.html": "MOHfHsuI+CL4nPwyAQjuFCAjFomNep+vcvjL0sLDlbw",
"vs/code/electron-sandbox/workbench/workbench.js": "UfEYJUwE/3rVxokZpMqXUk+OC+ZVfikR++K0yTZ+on8"
},
"version": "1.91.1"
"version": "1.91.1",
"target": "user"
}
2 changes: 1 addition & 1 deletion src/vs/platform/update/common/update.config.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ configurationRegistry.registerConfiguration({
},
'update.enableWindowsBackgroundUpdates': {
type: 'boolean',
default: true,
default: false,
scope: ConfigurationScope.APPLICATION,
title: localize('enableWindowsBackgroundUpdatesTitle', "Enable Background Updates on Windows"),
description: localize('enableWindowsBackgroundUpdates', "Enable to download and install new VS Code versions in the background on Windows."),
Expand Down
20 changes: 11 additions & 9 deletions src/vs/platform/update/electron-main/updateService.win32.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,17 @@ export class Win32UpdateService extends AbstractUpdateService implements IRelaun
}).then(packagePath => {
this.availableUpdate = { packagePath };
this.setState(State.Downloaded(update));

const fastUpdatesEnabled = this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
if (fastUpdatesEnabled) {
if (this.productService.target === 'user') {
this.doApplyUpdate();
}
} else {
this.setState(State.Ready(update));
}
// NOTE: pear does not support fast updates. so we are setting the state to ready.
this.setState(State.Ready(update));

// const fastUpdatesEnabled = this.configurationService.getValue('update.enableWindowsBackgroundUpdates');
// if (fastUpdatesEnabled) {
// if (this.productService.target === 'user') {
// this.doApplyUpdate();
// }
// } else {
// this.setState(State.Ready(update));
// }
});
});
})
Expand Down
Loading