Skip to content

Commit

Permalink
Add comment indicating that this is the release/test brach
Browse files Browse the repository at this point in the history
  • Loading branch information
aguscas committed Jun 27, 2024
1 parent db2c870 commit 098a4fc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions docs/challenge.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,4 @@ The training script `./challenge/train.py` used all the data we have for trainin
**REMARKS**:
- There are better ways of dealing with this last problem. Instead of training inside the `cd.yml`, we could have a model registry (using for example, MLflow), and then deploying our API with a model we have available in our model registry.
- Even though some variables like the project name and the key for my Service Account are treated as secret variables in the repository, I am aware that some variables are still hardcoded (and even the project name which is 'secret', is explicitly mentioned a few times in this markdown documentation just to simplify the exposition). One hardcoded variable is for example `STRESS_URL` in the Makefile, which shouldn't be harcoded. However, I still added a few steps in the `cd.yml` to get the URL to my API when it deploys with gcloud, and uses that URL to run the stress-test.
- After everything worked with the main branch, I modified my `cd.yml` file to handle deployments based on different branches (main, develop, and release/*), by including conditional logic within the deployment steps or create separate jobs for each branch scenario.

- After everything worked with the main branch, I modified my `cd.yml` file to handle deployments based on different branches (main, develop, and release/*), by including conditional logic within the deployment steps or create separate jobs for each branch scenario. The current branch you are seeing corresponds to the release/test branch.

0 comments on commit 098a4fc

Please sign in to comment.