Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolo nas demo #274

Merged
merged 3 commits into from
Jan 30, 2024
Merged

yolo nas demo #274

merged 3 commits into from
Jan 30, 2024

Conversation

agosl
Copy link
Contributor

@agosl agosl commented Aug 14, 2023

Add a new demo using Yolo Nas as the object detector

Copy link
Collaborator

@javiber javiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Just left some nitpicking and an idea to discuss in the group

MAX_DISTANCE: int = 10000


import super_gradients
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports should be at the top, before the constants

return detections


def yolo_detections_to_norfair_detections(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to implement in this PR but to think about and maybe add to the backlog

We've used this function so often that I believe it should be included in Norfair's utils. Maybe rename it to xywh_detections_to_norfair and call it with yolo_detections.xywh


RUN pip install git+https://github.com/tryolabs/norfair.git@master#egg=norfair

RUN pip install super-gradients
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should the requirements from requirements.txt or remove the file

@@ -0,0 +1 @@
super-gradient==3.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@aguscas
Copy link
Collaborator

aguscas commented Jan 30, 2024

Could we maybe add a mention of this demo in the main README.md? It could fit well in the adding tracking to different detectors section.

@aguscas
Copy link
Collaborator

aguscas commented Jan 30, 2024

Could we maybe add a mention of this demo in the main README.md? It could fit well in the adding tracking to different detectors section.

I have just realized that we need to have It in the master's first in order to provide a link to the demo from the main README, so forget whatever I said there.

@aguscas aguscas merged commit a3f191f into tryolabs:master Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants