Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace any print() + exit() combos with raise #259

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

quantumdot
Copy link
Contributor

Addressing #256, replace any instances of the print() + exit() pattern with an appropriate raise of an error.

@DiegoFernandezC
Copy link
Member

DiegoFernandezC commented Mar 31, 2023

Hey @quantumdot, thanks for your contribution.

I think that your changes make sense, but we need to make sure that these changes work well in all cases.

I add a list that includes the cases that I tested. I will edit it to include the future test cases that I will do.

  1. Generate a new distance function that returns a None value. I passed it to the Tracker and check this ValueError.
  2. Sent a list that did not contain a Detection instance to the update method to test this ValueError.
  3. Pass a list of points with the following dimension (2,2,2) to check this ValueError.
  4. OpenCV import fail
  5. _fail function

@aguscas aguscas force-pushed the replace-exit-with-raise branch from 3444b9d to fd49642 Compare January 30, 2024 15:54
@aguscas aguscas merged commit 5fe30c0 into tryolabs:master Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants