-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VIT-7375] Apple Health Kit: add support for nutritional data #239
Merged
ItachiEU
merged 5 commits into
main
from
filip/vit-7375-apple-health-kit-add-support-for-nutritional-data
Sep 10, 2024
Merged
[VIT-7375] Apple Health Kit: add support for nutritional data #239
ItachiEU
merged 5 commits into
main
from
filip/vit-7375-apple-health-kit-add-support-for-nutritional-data
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
reviewed
Sep 9, 2024
Sources/VitalCore/Core/Client/Data Models/Patches/QuantitySample.swift
Outdated
Show resolved
Hide resolved
andersio
reviewed
Sep 9, 2024
andersio
reviewed
Sep 9, 2024
andersio
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but we need to resolve the caffiene/water/meal overlap.
andersio
reviewed
Sep 9, 2024
andersio
reviewed
Sep 10, 2024
andersio
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the large PR, but in my defence most of the lines is just listing all the different nutrients in different forms 🙈