-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix filecoin bugs #958
fix filecoin bugs #958
Conversation
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.01%
==========================================
Files 425 425
Lines 12220 12222 +2
==========================================
+ Hits 11468 11469 +1
- Misses 752 753 +1
Continue to review full report at Codecov.
|
ok Co-authored-by: hewig <[email protected]>
you need to write tests to fix codecov warning |
So 0 value is not added to encoded data? Why? How can decode return the original value then? I have doubts. |
https://github.com/filecoin-project/cpp-filecoin/blob/master/core/primitives/big_int.hpp:18
|
For test: take over from branch ar/filecoinfix . |
Please fix test coverage, otherwise PR will be closed. You can take over tests from branch ar/filecoinfix . |
Please close pr. |
Description
Testing instructions
Types of changes
Checklist
[WIP]
if necessary.