Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filecoin bugs #958

Closed
wants to merge 2 commits into from
Closed

Conversation

spring820313
Copy link

Description

Testing instructions

Types of changes

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #958 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.01%     
==========================================
  Files         425      425              
  Lines       12220    12222       +2     
==========================================
+ Hits        11468    11469       +1     
- Misses        752      753       +1     
Impacted Files Coverage Δ
src/Filecoin/Transaction.cpp 96.96% <50.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25467e1...c43277b. Read the comment docs.

@hewigovens
Copy link
Contributor

you need to write tests to fix codecov warning

@optout21
Copy link
Contributor

So 0 value is not added to encoded data? Why? How can decode return the original value then? I have doubts.

@spring820313
Copy link
Author

spring820313 commented May 18, 2020

So 0 value is not added to encoded data? Why? How can decode return the original value then? I have doubts.

https://github.com/filecoin-project/cpp-filecoin/blob/master/core/primitives/big_int.hpp:18

GitHub
GitHub is where people build software. More than 50 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@optout21
Copy link
Contributor

For test: take over from branch ar/filecoinfix .

@optout21
Copy link
Contributor

Please fix test coverage, otherwise PR will be closed. You can take over tests from branch ar/filecoinfix .

@spring820313
Copy link
Author

Please fix test coverage, otherwise PR will be closed. You can take over tests from branch ar/filecoinfix .

Please close pr.

@hewigovens hewigovens closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
4 participants