Build sample apps in CI #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
==========================================
+ Coverage 92.51% 92.53% +0.02%
==========================================
Files 418 418
Lines 12141 12162 +21
==========================================
+ Hits 11232 11254 +22
+ Misses 909 908 -1
Continue to review full report at Codecov.
|
|
Note: very small FIO test extension inlcuded to not create a separate small PR :) |
hewigovens
reviewed
Apr 1, 2020
hewigovens
reviewed
Apr 3, 2020
madcake
approved these changes
Apr 3, 2020
hewigovens
approved these changes
Apr 14, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vikmeup
approved these changes
Apr 15, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
checks are not refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid breakage, build the sample apps in every CI. Script to build all sample apps. See #910 , #904 .
Testing instructions
./tools/samples-build
Types of changes
New script to build the sample apps.
Checklist
[WIP]if necessary.