Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Coins.cpp, coin data as a const map #900

Merged
merged 7 commits into from
Mar 24, 2020
Merged

Refactor Coins.cpp, coin data as a const map #900

merged 7 commits into from
Mar 24, 2020

Conversation

optout21
Copy link
Contributor

Description

Refactor the generated Coins.cpp files, instead of independent methods with large switch statements, create a map with all coin data, and retrieve data from there.
Motivation: data is closer to the coins.json file. Solves in part #885 .

Testing instructions

Build, check src/Generated/Coins.cpp.

Unit tests.

Types of changes

  • Minor internal refactor

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #900 into master will increase coverage by 0.02%.
The diff coverage is 97.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   92.42%   92.44%   +0.02%     
==========================================
  Files         417      418       +1     
  Lines       12056    12119      +63     
==========================================
+ Hits        11143    11204      +61     
- Misses        913      915       +2     
Impacted Files Coverage Δ
src/Coin.cpp 98.58% <95.23%> (-1.42%) ⬇️
src/Coin.h 100.00% <100.00%> (ø)
src/DerivationPath.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee15d8b...67fe3df. Read the comment docs.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@optout21
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@optout21 optout21 changed the title [WIP] Refactor Coins.cpp, coin data as a const map Refactor Coins.cpp, coin data as a const map Mar 21, 2020
@optout21
Copy link
Contributor Author

I'm afraid CI teawking is needed.

@optout21 optout21 merged commit fcd1f04 into master Mar 24, 2020
@optout21 optout21 deleted the ar/885_1 branch March 24, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
3 participants