Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in EthereumAbi encoder with wrong parameter type #896

Closed
wants to merge 2 commits into from

Conversation

optout21
Copy link
Contributor

Description

Fix crash in EthereumAbi encoder with wrong parameter type. Fixes #895 .

Testing instructions

Unit tests, incl. new test.

Types of changes

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@optout21
Copy link
Contributor Author

Wrong branch, correct PR is #897 .

@optout21 optout21 closed this Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #896 into master will increase coverage by <.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   92.41%   92.42%   +<.01%     
==========================================
  Files         417      417              
  Lines       12040    12078      +38     
==========================================
+ Hits        11127    11163      +36     
- Misses        913      915       +2
Impacted Files Coverage Δ
src/Coin.cpp 100% <ø> (ø) ⬆️
src/interface/TWEthereumAbiFunction.cpp 94.75% <88.23%> (-0.33%) ⬇️
src/Harmony/Staking.h 98.33% <0%> (+0.08%) ⬆️
src/Harmony/Signer.cpp 97.28% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587e10b...938beee. Read the comment docs.

@optout21 optout21 deleted the ar/ethabiparam branch March 20, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in EtehreumAbi encoder when wrong parameter type is requested Adopt Zilliqa to bech32 address format
1 participant