Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Solana implementation, Solana v1.0 #881

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Mar 4, 2020

Description

Update to Solana v1.0 abi changes: staking and RPC sendTransaction

Testing instructions

Unit tests

Types of changes

  • Breaking change to Solana only

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #881 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
+ Coverage   92.04%   92.04%   +<.01%     
==========================================
  Files         343      343              
  Lines       11669    11670       +1     
==========================================
+ Hits        10741    10742       +1     
  Misses        928      928
Impacted Files Coverage Δ
src/Solana/Signer.cpp 100% <100%> (ø) ⬆️
src/Solana/Transaction.h 98.65% <100%> (ø) ⬆️
src/Solana/Transaction.cpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecee8b...113d556. Read the comment docs.

@hewigovens hewigovens requested review from optout21 and vikmeup March 4, 2020 23:47
@vikmeup vikmeup merged commit ef93f8b into trustwallet:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants