Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement zilliqa bech32 address #445

Merged
merged 6 commits into from
May 21, 2019
Merged

implement zilliqa bech32 address #445

merged 6 commits into from
May 21, 2019

Conversation

hewigovens
Copy link
Contributor

Fixes #444

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #445 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   81.53%   81.56%   +0.03%     
==========================================
  Files         247      247              
  Lines        5725     5729       +4     
==========================================
+ Hits         4668     4673       +5     
+ Misses       1057     1056       -1
Impacted Files Coverage Δ
src/interface/TWHRP.cpp 96.66% <100%> (+0.37%) ⬆️
src/interface/TWZilliqaAddress.cpp 84.61% <100%> (ø)
src/Zilliqa/Address.h 100% <100%> (ø) ⬆️
src/Zilliqa/AddressChecksum.cpp 100% <100%> (ø) ⬆️
src/Coin.cpp 78.04% <100%> (ø) ⬆️
src/Zilliqa/Signer.cpp 96.87% <100%> (ø) ⬆️
src/Cosmos/Address.cpp 89.47% <0%> (+5.26%) ⬆️
src/Cosmos/Address.h 75% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32310c0...a6d92d6. Read the comment docs.

@hewigovens hewigovens requested a review from vikmeup May 20, 2019 15:16
@hewigovens hewigovens merged commit bdfb93b into master May 21, 2019
@hewigovens hewigovens deleted the xt/zilliqa-bech32 branch May 21, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
1 participant