Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRC20]: Fix bug when revealing BRC20 with extra P2TR #4152

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Fixes {"error":"-26: non-mandatory-script-verify-flag (Invalid Schnorr signature)"} bug when spending P2TR script-path and key-path UTXOs at the same transaction.

How to test

Run Rust tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Dec 5, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.30 MB

➡️ aarch64-apple-ios-sim: 12.30 MB

➡️ aarch64-linux-android: 15.82 MB

➡️ armv7-linux-androideabi: 13.50 MB

➡️ wasm32-unknown-emscripten: 11.22 MB

@satoshiotomakan satoshiotomakan merged commit eb408ea into master Dec 6, 2024
11 of 12 checks passed
@satoshiotomakan satoshiotomakan deleted the s/brc20-taproot branch December 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant