[Security]: Revert TON Mnemonic in dev branch #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b16771.
Binary size comparison➡️ aarch64-apple-ios: 12.30 MB ➡️ aarch64-apple-ios-sim: 12.30 MB ➡️ aarch64-linux-android: 15.82 MB ➡️ armv7-linux-androideabi: 13.50 MB ➡️ wasm32-unknown-emscripten: 11.22 MB |
|
FYI @evewlam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert TON 24-words specific mnemonic as we identified a security issue - possible DoS due to too strict restrictions of the TON Mnemonic words.
TON team is aware of their bad practice, that they don't follow the standard to generate private key: toncenter/tonweb-mnemonic#13
How to test
Run Rust, C++, iOS, Android, WASM tests
In addition, check master...s/dev-revert-ton-mnemonic - there must not be any changes related to TON
Types of changes
Revert
0b167710b325d299398ca82ef57ee8e630e54633commitChecklist
If you're adding a new blockchain