Add support for Nimiq Albatross PoS transaction serialization #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
requested review from
Milerius,
satoshiotomakan and
ar-g
as code owners
satoshiotomakan
approved these changes
Nov 18, 2024
| @@ -42,6 +43,7 @@ std::vector<uint8_t> Transaction::getPreImage() const { | |||
| encode32BE(vsh, data); | |||
| data.push_back(NETWORK_ID); | |||
| data.push_back(EMPTY_FLAGS); | |||
| data.push_back(0x00); // Sender Data size (+ 0 bytes of data) | |||
There was a problem hiding this comment.
Could you please add a link to the source code somewhere at the beginning of the function?
https://github.com/nimiq/core-rs-albatross/blame/b8ed402c9096ffb54afea52347b91ab7831e75de/primitives/transaction/src/lib.rs#L582
| @@ -9,13 +9,14 @@ | |||
|
|
|||
| namespace TW::Nimiq { | |||
|
|
|||
| const uint8_t NETWORK_ID = 42; | |||
| const uint8_t NETWORK_ID = 24; | |||
| const uint8_t EMPTY_FLAGS = 0; | |||
|
|
|||
| std::vector<uint8_t> Transaction::serialize() const { | |||
There was a problem hiding this comment.
Could you please add a link to the source code somewhere at the beginning of the function?
https://github.com/nimiq/core-rs-albatross/blame/b8ed402c9096ffb54afea52347b91ab7831e75de/primitives/transaction/src/lib.rs#L699
| const uint8_t EMPTY_FLAGS = 0; | ||
|
|
||
| std::vector<uint8_t> Transaction::serialize() const { | ||
| std::vector<uint8_t> data; | ||
|
|
||
| data.push_back(0x00); // Basic TX type | ||
| data.push_back(0x00); // Signature Proof type and flags (Ed25519 type and no flags) |
There was a problem hiding this comment.
We should add an if statement here to avoid breaking changes
satoshiotomakan
merged commit 5cc17bb
into
trustwallet:s/nimiq-albatross
12 checks passed
5 tasks
satoshiotomakan
added a commit
that referenced
this pull request
Nov 18, 2024
* Add support for Nimiq Albatross PoS transaction serialization (#4110) * Update Nimiq Transaction encoding for Albatross PoS * Update tests * [Nimiq]: Add networkId parameter to SigningInput * [Nimiq]: Fix iOS test * [Nimiq]: Fix invalid integer type cast * [Nimiq]: Fix iOS test --------- Co-authored-by: Sören Schwert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transaction format for both signing and sending changed slightly for Nimiq Albatross PoS, to encode optional sender data and support more signature methods (now also supports ECDSA and WebAuthn).
How to test
To test, connect your wallet to a Nimiq PoS testnet node (provided in our joined Telegram channel). To be valid in the testnet, the
NETWORK_IDhas to be set to5.Types of changes
Checklist
If you're adding a new blockchain