Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polkadot extrinsic encoding to support new spec for Acala #4107

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

doom
Copy link
Contributor

@doom doom commented Nov 13, 2024

Description

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Nov 13, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.29 MB

➡️ aarch64-apple-ios-sim: 12.29 MB

➡️ aarch64-linux-android: 15.80 MB

➡️ armv7-linux-androideabi: 13.48 MB

➡️ wasm32-unknown-emscripten: 11.20 MB

@JaimeToca
Copy link
Collaborator

Successful simulation

curl --location 'https://acala-api.twnodes.com/transaction/fee-estimate' \
--header 'Content-Type: application/json' \
--data '{"tx":"0x45028400e9590e4d99264a14a85e21e69537e4a64f66a875d38cb8f76b305f41fabe24a900a9c3111fb98507f929e4da9aea30f996c69d2790e5a1e789f91634dc5d4f6afb155e0f1ea623498c04778f06dbc698109c3490c3e6b4c33d8e58ebab82a0f40bd5020000000a0000c8c602ded977c56076ae38d98026fa669ca10d6a2b5a0bfc4086ae7668ed1c60070010a5d4e8"}
'

Copy link
Member

@rkokhatskyi rkokhatskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkokhatskyi rkokhatskyi merged commit 3772536 into master Nov 13, 2024
13 checks passed
@rkokhatskyi rkokhatskyi deleted the enable-new-spec-for-acala branch November 13, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants