Export bech32 and bech32m functions #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10gic
requested review from
Milerius,
satoshiotomakan and
ar-g
as code owners
10gic
changed the title
satoshiotomakan
requested changes
Nov 7, 2024
10gic
force-pushed
the
export-bech32-functions
branch
from
84f463d to
d134eff
Compare
|
Hi @satoshiotomakan, could you help review it? Also, could you trigger CI to run the tests? I can't run the iOS, Android, or TypeScript tests due to my local environment. |
10gic
changed the title
satoshiotomakan
previously approved these changes
Nov 8, 2024
10gic
force-pushed
the
export-bech32-functions
branch
from
67675e2 to
663e434
Compare
10gic
force-pushed
the
export-bech32-functions
branch
from
663e434 to
588758e
Compare
|
Hi @satoshiotomakan, if you have a moment, could you please proceed with merging it? I appreciate your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export bech32 and bech32m functions. Fix issue #4100
How to test
Run Rust, C++, iOS, Android tests
Types of changes
Checklist
If you're adding a new blockchain