Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRON]: Add transaction memo #4099

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[TRON]: Add transaction memo #4099

merged 2 commits into from
Nov 6, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Add transaction memo to the TRON transaction builder.

How to test

Run C++ tests

Types of changes

Add Proto::Tron::Transaction::memo protobuf parameter.

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Nov 5, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.20 MB

➡️ aarch64-apple-ios-sim: 12.21 MB

➡️ aarch64-linux-android:

- 15.67 MB
+ 15.67 MB 	 +1 KB

➡️ armv7-linux-androideabi: 13.37 MB

➡️ wasm32-unknown-emscripten: 11.12 MB

rkokhatskyi
rkokhatskyi previously approved these changes Nov 5, 2024
@satoshiotomakan satoshiotomakan merged commit c4907d4 into master Nov 6, 2024
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/tron-memo branch November 6, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants