Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Evmos]: Fix signing, prehash, compile for Native Evmos #3406

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Fix signing, prehash, compile for Native Evmos.

Breaking changes

publicKeyType was changed for Evmos in registry.json to secp256k1 as it's used in transaction compiling.
Please also note that secp256k1Extended still needs to be used to create an address.

How to test

Run C++, Android, Swift tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan satoshiotomakan marked this pull request as draft September 1, 2023 13:13
@satoshiotomakan satoshiotomakan marked this pull request as draft September 1, 2023 13:13
@satoshiotomakan satoshiotomakan marked this pull request as ready for review September 1, 2023 14:33
@Milerius Milerius merged commit a369164 into master Sep 1, 2023
12 checks passed
@Milerius Milerius deleted the s/fix-evmos branch September 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants