Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): password label set to password input field id on sign in #2618

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix(storybook): password label set to password input field id on sign in #2618

merged 3 commits into from
Oct 18, 2023

Conversation

aybeedee
Copy link
Contributor

@aybeedee aybeedee commented Oct 4, 2023

Summary

Password field label has been correctly associated with the password input field id on the auth sign in template example.

Related Issues or PRs

Closes #2610

How To Test

  • Go to the page template for authentication sign in
  • Use an automated accessibility checker or developer tools
  • Check the correct association of the password label with its input field

Screenshots (optional)

react-uswds-2610

@aybeedee aybeedee requested a review from a team as a code owner October 4, 2023 18:15
shkeating
shkeating approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@shkeating shkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thanks :D

@brandonlenz brandonlenz enabled auto-merge (squash) October 17, 2023 23:53
@brandonlenz
Copy link
Contributor

@all-contributors please add @aybeedee for code

@allcontributors
Copy link
Contributor

@brandonlenz

We had trouble processing your request. Please try again later.

@brandonlenz brandonlenz mentioned this pull request Oct 18, 2023
Closed
@brandonlenz
Copy link
Contributor

@all-contributors please add @aybeedee for code

@allcontributors
Copy link
Contributor

@brandonlenz

We had trouble processing your request. Please try again later.

@brandonlenz brandonlenz merged commit eae195e into trussworks:main Oct 18, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
@brandonlenz brandonlenz mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shkeating shkeating shkeating approved these changes

@brandonlenz brandonlenz brandonlenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] password field label must be correctly programmatically associated on auth sign in template example
3 participants
@aybeedee @brandonlenz @shkeating