fix!: Label is mandatory for TimePicker component (#2629)

BREAKING CHANGE: TimePicker implementations must specify a label prop
trussworks · Oct 27, 2023 · c7f00d3 · c7f00d3
1 parent 59dffd1
commit c7f00d3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/components/forms/TimePicker/TimePicker.stories.tsx b/src/components/forms/TimePicker/TimePicker.stories.tsx
@@ -39,7 +39,7 @@ export const completeTimePicker = (
     <TimePicker
       id="appointment-time"
       name="appointment-time"
-      label="Appointment Time"
+      label="Appointment time"
       hint="hh:mm"
       onChange={noop}
       disabled={argTypes.disabled}
@@ -54,6 +54,7 @@ export const defaultTimePicker = (
     <TimePicker
       id="appointment-time"
       name="appointment-time"
+      label="Appointment time"
       onChange={noop}
       disabled={argTypes.disabled}
     />
@@ -67,7 +68,7 @@ export const withMinAndMaxTimes = (
     <TimePicker
       id="appointment-time"
       name="appointment-time"
-      label="Appointment Time"
+      label="Appointment time"
       hint="hh:mm (9:00am - 5:00pm)"
       minTime="9:00"
       maxTime="17:00"
@@ -84,7 +85,7 @@ export const withDefaultValue = (
     <TimePicker
       id="appointment-time"
       name="appointment-time"
-      label="Appointment Time"
+      label="Appointment time"
       hint="hh:mm"
       defaultValue="12:00"
       onChange={noop}

diff --git a/src/components/forms/TimePicker/TimePicker.test.tsx b/src/components/forms/TimePicker/TimePicker.test.tsx
@@ -12,6 +12,7 @@ describe('TimePicker Component', () => {
   const testProps = {
     id: 'appointment-time',
     name: 'appointment-time',
+    label: 'Appointment time',
     onChange: jest.fn(),
   }
 

diff --git a/src/components/forms/TimePicker/TimePicker.tsx b/src/components/forms/TimePicker/TimePicker.tsx
@@ -18,7 +18,7 @@ type BaseTimePickerProps = {
   id: string
   name: string
   onChange: (val?: string) => void
-  label?: string
+  label: string
   defaultValue?: string
   disabled?: boolean
   minTime?: string

diff --git a/yarn.lock b/yarn.lock
@@ -16237,4 +16237,4 @@ zip-stream@^4.1.0:
 zwitch@^1.0.0:
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/zwitch/-/zwitch-1.0.5.tgz#d11d7381ffed16b742f6af7b3f223d5cd9fe9920"
-  integrity sha512-V50KMwwzqJV0NpZIZFwfOD5/lyny3WlSzRiXgA0G7VUnRlqttta1L6UQIHzd6EuBY/cHGfwTIck7w1yH6Q5zUw==
+  integrity sha512-V50KMwwzqJV0NpZIZFwfOD5/lyny3WlSzRiXgA0G7VUnRlqttta1L6UQIHzd6EuBY/cHGfwTIck7w1yH6Q5zUw==