Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde(rename) #38

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Use serde(rename) #38

merged 2 commits into from
Apr 3, 2024

Conversation

sosthene-nitrokey
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey commented Feb 13, 2024

No description provided.

@sosthene-nitrokey
Copy link
Contributor Author

sosthene-nitrokey commented Feb 13, 2024

trussed-auth also creates a lot of intermediate files. Maybe we should consider migrating to removing the dat intermediary folders for the backend. That would require overriding the filestore to allow it to optionally remove the dat.

For example for a single PIN in the secrets app:

 /
├──  backend-auth
│   └──  dat
│       └── [  16]  salt
├──  secrets
│   └──  backend-auth
│       └──  dat
│           ├── [  16]  application_salt
│           └── [ 118]  pin.00
└──  trussed
    └── dat
        └── [  32]  rng-state.bin

This is also made worse when both the software impl of trussed-auth and the SE050 impl are used.

@sosthene-nitrokey sosthene-nitrokey changed the title Use serde-indexed to save space Use serde(rename) Feb 14, 2024
@robin-nitrokey
Copy link
Member

Missing changelog entry, otherwise LGTM!

@sosthene-nitrokey sosthene-nitrokey merged commit 0c03037 into main Apr 3, 2024
2 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the space-opt branch April 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants