Fix to vulnerability reported in #1 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzox
commented
Nov 3, 2017
frenzox
commented
- Fixed vulnerability discussed in Vulnerable to token substitution attacks. #1 by using appsecret_proof.
- Added fields option so the user can choose profile fields to fetch.
paventuri
reviewed
Nov 18, 2017
lib/index.js
Outdated
| fields = null; | ||
| } | ||
|
|
||
| if (!Array.isArray(fields)) { |
There was a problem hiding this comment.
Hi @frenzox, I think if you pass opts as function, this condition will be met and the error thrown. I believe the idea was that fields should not be required.
There was a problem hiding this comment.
You're completely right! I will take a look into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.