Do not deepcopy the cache! #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Fennick <[email protected]>
|
Looks like PRs should be opened against the |
|
Thank you for the suggestion. I agree that the deepcopy operation was unnecessary (on the namespace's cache and other parts). Your suggested edit, however, still uses deepcopy. I would suggest the following: # Do not reuse the namespace object, making an identical copy
ns = self.add_namespace(Namespace(namespace.prefix, namespace.uri))and we can also remove the deepcopy import that is no longer required. |
|
@jfennick Merged. Thanks a lot! |
|
No problem! Any chance for a point release soon? We have some users that are currently affected by this. |
|
No promise, but I will try to make a release this weekend. |
|
@jfennick I've made a release. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deepcopy'ing the cache is unnecessary and is causing massive performance problems for certain uses cases (specifically, large directories). This change fixes the performance problems.