Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128390 / 24.10.2 / Adjust children selection options for draid pools #11119

Closed
wants to merge 1 commit into from

Conversation

RehanY147
Copy link
Contributor

Changes:

Adjusts min allowed child count when creating dRaid pools

Testing:

The children select's minimum value when creating a draid pool should be calculated based on this formula

max = Math.min(maxAvailableDisks, 255)
parity = 1 if dRaid1, 2 if dRaid2, 3 if dRaid3
min = (data vdev disks) + (hot spares count) + parity

@RehanY147 RehanY147 requested a review from a team as a code owner November 29, 2024 23:23
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team November 29, 2024 23:23
@bugclerk bugclerk changed the title Adjust children selection options for draid pools NAS-128390 / 24.10.2 / Adjust children selection options for draid pools Nov 29, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@6a57500). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11119   +/-   ##
=====================================================
  Coverage                      ?   79.96%           
=====================================================
  Files                         ?     1573           
  Lines                         ?    51467           
  Branches                      ?     5939           
=====================================================
  Hits                          ?    41154           
  Misses                        ?    10313           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RehanY147
Copy link
Contributor Author

Backport

@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

Unable to backport: no backport-* labels found.

@undsoft
Copy link
Collaborator

undsoft commented Dec 2, 2024

I don't think we need this in Electric Eel.

@undsoft undsoft closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants