-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132372 / 25.04 / Add /dev/zvol
root for explorer
#11106
base: master
Are you sure you want to change the base?
Conversation
/dev/zvol
root for explorer/dev/zvol
root for explorer
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11106 +/- ##
========================================
Coverage 82.38% 82.38%
========================================
Files 1648 1647 -1
Lines 57694 57876 +182
Branches 5944 5958 +14
========================================
+ Hits 47532 47682 +150
- Misses 10162 10194 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to address the [ENOENT] Directory /dev/zvol does not exist
error that may happen if user does not have any zvols.
directoriesOnly?: boolean; | ||
showHiddenFiles?: boolean; | ||
includeSnapshots?: boolean; | ||
dsAndZvols?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not abbreviate
Changes:
Adds option to load zvols alongside datasets by providing two root paths.
/dev/zvol
alongside/mnt
when callingfilesystem.listdir
endpoint.ix-explorer
root
property should be set to/
for this. Defaultroot
forix-explorer
is/mnt
Testing:
Test on the TrueCloud Task Form. The path explorer should show
'/'
as it's root. When expanded, it should show two children paths.'/mnt'
and'/dev/zvol'
. When expanded,'/mnt'
should show the normal datasets and'/dev/zvol'
should show the zvols.