Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132372 / 25.04 / Add /dev/zvol root for explorer #11106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RehanY147
Copy link
Contributor

Changes:

Adds option to load zvols alongside datasets by providing two root paths. /dev/zvol alongside /mnt when calling filesystem.listdir endpoint. ix-explorer root property should be set to / for this. Default root for ix-explorer is /mnt

Testing:

Test on the TrueCloud Task Form. The path explorer should show '/' as it's root. When expanded, it should show two children paths. '/mnt' and '/dev/zvol'. When expanded, '/mnt' should show the normal datasets and '/dev/zvol' should show the zvols.

@RehanY147 RehanY147 requested a review from a team as a code owner November 28, 2024 00:33
@RehanY147 RehanY147 requested review from bvasilenko and removed request for a team November 28, 2024 00:33
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132372: Add /dev/zvol root for explorer NAS-132372 / 25.04 / Add /dev/zvol root for explorer Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (28145e9) to head (33f1853).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/filesystem.service.ts 45.45% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11106    +/-   ##
========================================
  Coverage   82.38%   82.38%            
========================================
  Files        1648     1647     -1     
  Lines       57694    57876   +182     
  Branches     5944     5958    +14     
========================================
+ Hits        47532    47682   +150     
- Misses      10162    10194    +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to address the [ENOENT] Directory /dev/zvol does not exist error that may happen if user does not have any zvols.

directoriesOnly?: boolean;
showHiddenFiles?: boolean;
includeSnapshots?: boolean;
dsAndZvols?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not abbreviate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants