NAS-132657 / 25.04 / Remove explicit calls to syslog.syslog module #15039
+84
−150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by a community user, we're doing a bunch of random/weird things with syslog messages. While the community member focused on the mail functionality, I found we had sprinkled in random syslog calls all over the place.
There are a bunch of problems with what we were doing:
syslog-ng
. If a remote syslog server is configured, then syslog-ng automatically monitors that file and sends those messages to the remote systemBecause we already forward relevant log messages via
syslog-ng
, this removes the explicit calls tosyslog.syslog
module as to not cause confusion. While I'm here, I went ahead and formatted/fixed up thefind_aliases_for_smtplib.py
script.