NAS-132078 / 25.04 / refactor kerberos plugin to use api_method #14808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
This commit performs boiler-plate conversion of kerberos.py to new api_method schema. kerberos.config and kerberos.update are deliberately excluded at this point due to in-progress changes to ConfigService api_method plumbing.
anodos325
force-pushed
the
refactor-kerberos-api-method
branch
from
14cffa6
to
0331106
Compare
creatorcary
reviewed
Nov 8, 2024
|
|
||
| class KerberosCcacheOptions(BaseModel): | ||
| """ Private API entry defined for normalization purposes """ | ||
| ccache: Literal[ |
There was a problem hiding this comment.
We could consider ccache: krb5ccache = krb5ccache.SYSTEM as long as we handle the enum fields properly in the endpoints.
|
|
||
| class KerberosKinitResult(BaseModel): | ||
| """ Private API entry defined for normalization purposes """ | ||
| result: Literal[None] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit performs boiler-plate conversion of kerberos.py to new api_method schema. kerberos.config and kerberos.update are deliberately excluded at this point due to in-progress changes to ConfigService api_method plumbing.