Fix loopback interfaces support - missing braces in if #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@troglobit appreciate if you can take a look.. thanks! |
|
It's in my backlog, albeit with a low priority. I'll see when I can have a look and test your patch. |
|
@troglobit friendly reminder :) Note it's a small local change - easy to get convinced that the IFF_LOOPBACK check is not related to the generated log and the current code doesn't make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing if braces caused to skip the interface, even if it's IFF_LOOPBACK (only the log print is inside the if clause)