Fix Coverity CID #89536: Unchecked return value from library

The daemonizing code in main() failed to check the return value of open() when redirecting STDIN/STDOUT/STDERR to someplace safe. Signed-off-by: Joachim Nilsson <[email protected]>
troglobit · Apr 20, 2015 · 907233f · 907233f
1 parent 92b90e3
commit 907233f
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/main.c b/main.c
@@ -477,12 +477,17 @@ int main(int argc, char *argv[])
 	haveterminal = 0;
 	if (fork())
 	    exit(0);
-	close(0);
-	close(1);
-	close(2);
-	open("/", 0);
-	dup2(0, 1);
-	dup2(0, 2);
+
+	close(STDIN_FILENO);
+	close(STDOUT_FILENO);
+	close(STDERR_FILENO);
+
+	n = open("/dev/null", O_RDWR, 0);
+	if (n >= 0) {
+	    dup2(n, STDIN_FILENO);
+	    dup2(n, STDOUT_FILENO);
+	    dup2(n, STDERR_FILENO);
+	}
 #ifdef SYSV
 	setpgrp();
 #else
@@ -499,9 +504,8 @@ int main(int argc, char *argv[])
 #endif /* SYSV */
     } /* End of child process code */
 
-    if (pidfile(NULL)) {
+    if (pidfile(NULL))
 	warn("Cannot create pidfile");
-    }
 
     /*
      * Main receive loop.