-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Checkpointing for T8codeMesh #1980
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 96.37% 95.44% -0.93%
==========================================
Files 480 480
Lines 37855 38028 +173
==========================================
- Hits 36482 36295 -187
- Misses 1373 1733 +360
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Concerning the failing invalidations check, see timholy/SnoopCompile.jl#397 |
@benegee As expected, several tests fail since some routines became obsolete with the breaking t8code 3.0.0 release. We have to iron out these issues first. I suggest we fix these problems in this PR #1939 first since the changes are minimal on Trixi side. Then merge that PR into the checkpointing PR. |
…hub.com:trixi-framework/Trixi.jl into t8code-switch-to-own-cmesh-brick-implementation
…eature-t8codemesh-checkpointing
…ramework/Trixi.jl into feature-t8codemesh-checkpointing
This PR adds checkpointing for
T8codeMesh
. By this, routines likesave_mesh
andload_mesh
are supported.Closes #2044