fix: Move pinned memory size checks to PinnedMemoryManager and update C API version for new EnablePeerAccess API #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
approved these changes
Jun 6, 2024
|
@indrajit96 please update the title to be more representative of the actual changes. |
rmccorm4
changed the title
rmccorm4
approved these changes
Jun 6, 2024
Have added a brief description here, will add more detailed description in the Jira bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Added new flag for GPU peer access API control Added new flag for GPU peer access API control #361"
Seg Fault Details:
Triton tries to access pinned_memory_buffer here
Which was null because of the new change introduced in #361.
Triton behavior is to verify it failed to allocate pinned memory by looping through pinned_memory_buffer AND then do a malloc. This looks like a design choice made.