fix: Fix L0_request_cancellation and L0_backend_output_detail byte size checks #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
changed the title
rmccorm4
changed the title
jbkyang-nvi
previously approved these changes
May 31, 2024
jbkyang-nvi
reviewed
May 31, 2024
| @@ -175,7 +177,7 @@ class RequestCancellationTest : public ::testing::Test { | |||
| }; | |||
|
|
|||
| TRITONSERVER_Server* RequestCancellationTest::server_ = nullptr; | |||
| std::vector<int32_t> RequestCancellationTest::input0_data_(16, 1); | |||
| std::vector<int32_t> RequestCancellationTest::input0_data_(1000, 1); | |||
There was a problem hiding this comment.
Q: What's the point of changing it here?
There was a problem hiding this comment.
It has to match the std::vector<int64_t> input0_shape({1, 1000}); , which is also the shape specified in the config.pbtxt of the model being used for testing
kthui
previously approved these changes
Jun 1, 2024
kthui
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Recent byte size validation changes caught issues with the input metadata being provided by these tests.
This PR fixes this:
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
None
Where should the reviewer start?
N/A
Test plan:
Pre-existing tests
Caveats:
None
Background
None
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
None