Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated parameter handling #349

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Updated parameter handling #349

merged 6 commits into from
Jun 4, 2024

Conversation

nnshah1
Copy link
Contributor

@nnshah1 nnshah1 commented May 7, 2024 •
edited
Loading

  1. add support for double
  2. add support for mapping numpy.bool_ type to tritonserver data type
  3. changed dlpack dtype for bool to kDLBool, 8 (8bits) from KDLBool, 1 (1bits)

Discovered in sending sampling parameters to vLLM backend.

@nnshah1 nnshah1 requested a review from GuanLuo June 4, 2024 02:10
Tabrizian
Tabrizian reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add double type here too?

core/src/tritonserver.cc

Line 637 in 5fb865f

return "BYTES";

python/test/test_api.py Outdated Show resolved Hide resolved
python/tritonserver/_c/tritonserver_pybind.cc Show resolved Hide resolved
python/test/test_api.py Outdated Show resolved Hide resolved
@nnshah1
Copy link
Contributor Author

nnshah1 commented Jun 4, 2024

Do we need to add double type here too?

core/src/tritonserver.cc

Line 637 in 5fb865f

return "BYTES";

did a quick search and ammended a few other places

@nnshah1 nnshah1 merged commit 7752666 into main Jun 4, 2024
1 check passed
@nnshah1 nnshah1 deleted the nnshah1-datatype-updates branch June 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuanLuo GuanLuo GuanLuo approved these changes

@Tabrizian Tabrizian Tabrizian approved these changes

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnshah1 @Tabrizian @rmccorm4 @GuanLuo