Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Extend Common Compile Settings to Protobuf #123

Merged
merged 1 commit into from
Jul 11, 2024
Merged

build: Extend Common Compile Settings to Protobuf #123

merged 1 commit into from
Jul 11, 2024

Conversation

fpetrini15
Copy link
Contributor

@fpetrini15 fpetrini15 commented Jul 11, 2024 •
edited
Loading

Goal: Fix the Windows build which was failing to compile c++17 features due the GRPC repo bump in our third party repo.

@rmccorm4 rmccorm4 changed the title Extend Common Compile Settings to Protobuf build: Extend Common Compile Settings to Protobuf Jul 11, 2024
rmccorm4
rmccorm4 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GMTL 🚀

@fpetrini15 fpetrini15 merged commit e827f28 into main Jul 11, 2024
2 checks passed
@fpetrini15 fpetrini15 deleted the fpetrini-win-compile-fix branch July 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuanLuo GuanLuo GuanLuo approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpetrini15 @rmccorm4 @GuanLuo