Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use log level ERROR when logging backend errors with LOG_IF_ERROR #99

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented Jun 5, 2024

Related PR: triton-inference-server/core#367

  1. Use log level ERROR for LOG_IF_ERROR

Before, LOG_IF_ERROR would prefix the line with I for level INFO:

E0605 22:07:23.729999 1135 identity.cc:1175] request 0: failed to get copy buffer, error response sent
I0605 22:07:23.730046 1135 identity.cc:1189] failed setting string parameter: Invalid argument - response was nullptr
I0605 22:07:23.730084 1135 identity.cc:1193] failed setting integer parameter: Invalid argument - response was nullptr
I0605 22:07:23.730123 1135 identity.cc:1196] failed setting boolean parameter: Invalid argument - response was nullptr
I0605 22:07:23.730162 1135 identity.cc:1199] failed setting double parameter: Invalid argument - response was nullptr

After, it uses E for ERROR:

E0605 22:07:23.729999 1135 identity.cc:1175] request 0: failed to get copy buffer, error response sent
E0605 22:07:23.730046 1135 identity.cc:1189] failed setting string parameter: Invalid argument - response was nullptr
E0605 22:07:23.730084 1135 identity.cc:1193] failed setting integer parameter: Invalid argument - response was nullptr
E0605 22:07:23.730123 1135 identity.cc:1196] failed setting boolean parameter: Invalid argument - response was nullptr
E0605 22:07:23.730162 1135 identity.cc:1199] failed setting double parameter: Invalid argument - response was nullptr

  1. Add default TRITON_REPO_ORGANIZATION for building locally.

@rmccorm4 rmccorm4 changed the title chore: Use log level ERROR for logging errors with LOG_IF_ERROR chore: Use log level ERROR when logging backend errors with LOG_IF_ERROR Jun 5, 2024
@rmccorm4 rmccorm4 merged commit 25c4193 into main Jun 6, 2024
1 check passed
@rmccorm4 rmccorm4 deleted the rmccormick-fix-pinned-memory branch June 6, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants